chore: left-shift insight filtering and pagination into EvalClient - #2092
chore: left-shift insight filtering and pagination into EvalClient#2092nborges-aws wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2092 +/- ##
=========================================
Coverage 97.36% 97.37%
=========================================
Files 410 411 +1
Lines 24796 24879 +83
=========================================
+ Hits 24142 24225 +83
Misses 654 654 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,168 @@ | |||
| import { describe, expect, mock, test } from "bun:test"; | |||
There was a problem hiding this comment.
Does gateway have a seperate unit test for this? Can this be tested within the handler tests?
There was a problem hiding this comment.
gateway tests this via unit tests also: src/core/gateway.test.ts:65
jariy17
left a comment
There was a problem hiding this comment.
export type ListBatchInsightsResponse = Omit<ListBatchEvaluationsResponse, "batchEvaluations"> & {
batchEvaluations: BatchEvaluationSummary[];
};
I think this will remove all of results
@jariy17 This doesn't remove all results. It's a shortcut to avoid adding |
1f8181a to
1b61a60
Compare
Description
Move filtering and pagination handling logic into
EvalClientlistBatchInsightsAPI -- backed bylistBatchEvaluationsBatchInsightsPickerand restoresBatchEvaluationsPickerto eval-only interfaceThis is a follow up to PR #2078. Along with improving filtering/pagination handling, this PR scaffolds a standalone insights API and picker. This creates an existing degree of separation between insights and evaluations, proofing our code for any divergence between the two in the future.
Type of Change
Testing
How have you tested the change?
bun run test(1805 pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.