fix(status): show 'No target configured' instead of empty target label (#985) - #2077
Open
lvthillo wants to merge 1 commit into
Open
fix(status): show 'No target configured' instead of empty target label (#985)#2077lvthillo wants to merge 1 commit into
lvthillo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agentcore statusprinted an empty target label:AgentCore Status (target: )on projects with no deployment target configured (any freshagentcore createproject, since it writes an emptyaws-targets.json).Root cause: the status action always returned a
targetNamestring, substituting an empty string when no target was configured. The render layer only shows its "No target configured" fallback whentargetNameis missing entirely: an empty string counts as present, so the header printed a blank label. The fix is to leavetargetNameunset when there is no target, letting the existing fallback take over.Verified with the built CLI: header now renders
AgentCore Status (target: No target configured).Note:
status --jsonnow omitstargetNameinstead of emitting"targetName": "".Related Issue
#985
Closes #
#985
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.