feat(eval): imperative online-insight commands + BYO execution role - #2067
Open
jariy17 wants to merge 4 commits into
Open
feat(eval): imperative online-insight commands + BYO execution role#2067jariy17 wants to merge 4 commits into
jariy17 wants to merge 4 commits into
Conversation
… role Adds `agentcore eval online-insight` (create/get/list/pause/resume/delete) backed by dedicated CoreEvalClient methods (createOnlineInsight, getOnlineInsight, listOnlineInsights, setOnlineInsightExecutionStatus, deleteOnlineInsight). - create sets insights + optional clusteringConfig (never evaluators) and REQUIRES --execution-role-arn — no CLI-side auto-provisioning for insight configs. - read/lifecycle reuse the online-eval control-plane ops (same resource). Part 1 (draft). TODO: online-insight update; make online-eval --role-arn required + remove the shared auto-provisioning (onlineEvalExecutionRole).
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2067 +/- ##
============================================
+ Coverage 97.24% 97.26% +0.02%
============================================
Files 396 403 +7
Lines 24019 24291 +272
============================================
+ Hits 23357 23627 +270
- Misses 662 664 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
commented
Aug 22, 2026
| flags: [ | ||
| flag("name", "the name of the online insight config", z.string().optional()), | ||
| flag( | ||
| "execution-role-arn", |
Contributor
Author
There was a problem hiding this comment.
it should be --role-arn
| flag("name", "the name of the online insight config", z.string().optional()), | ||
| flag( | ||
| "execution-role-arn", | ||
| "IAM role the online insight assumes (required; not auto-provisioned)", |
Contributor
Author
There was a problem hiding this comment.
remove this: (required; not auto-provisioned)
| "IAM role the online insight assumes (required; not auto-provisioned)", | ||
| z.string().optional(), | ||
| ), | ||
| flag("agent", "harness ID or runtime ID whose traffic to sample", z.string().optional()), |
| @@ -0,0 +1,179 @@ | |||
| import { describe, expect, test } from "bun:test"; | |||
Contributor
Author
There was a problem hiding this comment.
It should use the golden test pattern that harness and runtime have.
added 2 commits
August 22, 2026 15:03
… drop mock test - rename --execution-role-arn -> --role-arn (match online-eval) - drop '(required; not auto-provisioned)' from the flag description - --agent description: runtime ID only - remove the TestCoreClient-based test; golden fixture test to follow
jariy17
marked this pull request as ready for review
August 22, 2026 15:11
This was referenced Aug 22, 2026
jariy17
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command structure
Also:
eval online-insight get | list | pause | resume | delete(by--id).What this does
eval online-insightcommand family (service-direct), sibling ofeval online-eval.CoreEvalClient:createOnlineInsight,getOnlineInsight,listOnlineInsights,setOnlineInsightExecutionStatus,deleteOnlineInsight.createsets the SDKinsights(+ optionalclusteringConfig), neverevaluators, and requires--execution-role-arn— insight configs are not auto-provisioned a role.OnlineEvaluationConfigresource).Service client (
CoreEvalClient)CreateOnlineInsightInput:name,samplingRate,insightIds(required),evaluationExecutionRoleArn(required),clusteringConfig?,sessionTimeoutMinutes?,filters?,enableOnCreate?,description?, and a source union (agent+endpoint?|dataSourceConfig). The impl mapsinsightIds → insights[{insightId}]onCreateOnlineEvaluationConfigCommandand passes the caller role straight through (nograntOnlineEvalScope).Decisions made (flag for review)
--execution-role-arn(net-new, non-breaking). Online-eval's--role-arnrename is deferred.CoreEvalClient(not a separate class file).TODO (remaining scope)
eval online-insight updateeval online-eval--role-arnrequired + remove shared auto-provisioning (onlineEvalExecutionRole.tsx, the?? autoProvisionfallback,--update-role, role-scope warning)Verification
tsc --noEmitclean for these changes. Unit test added (online-insight.test.tsx). Note:bun test/unbundledbun runfor theevalchain can't execute in the current sandbox (pre-existing missing@opentelemetry/otlp-transformerdeep-import that only the bundler resolves) — bug-bash uses the built bundle.