Fix compatibility with external CIMD URLs - #3154
Merged
Merged
Conversation
Appwrite's apps.get()/apps.list() no longer resolve CIMD URLs — appId is always a plain ID now. Detect URL-shaped OAuth2 client IDs in the console and fetch the Client ID Metadata Document directly from the browser, mapping its RFC 7591 fields onto Models.App for consent/device/applications rendering. Fetch or validation failures fall back to hostname-only branding so the flow never blocks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Console (appwrite/console)Project ID: Tip Schedule functions to run as often as every minute with cron expressions |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Greptile SummaryThe PR adds browser-side resolution of URL-shaped CIMD client IDs after the API stopped resolving them.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "chore(deps): raise the nanoid floor past..." | Re-trigger Greptile |
HarshMN2345
approved these changes
Aug 11, 2026
…-2v37-7h3g-55p8 bun audit fails the CI build on three high nanoid advisories. All fixes are within the existing semver ranges: the direct dependency and @melt-ui/svelte's nested copy move to 5.1.16, and the 3.x copies under @ai-sdk/provider-utils and postcss move to 3.3.17. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Original prompt
What changed
The API no longer resolves CIMD (Client ID Metadata Document) URLs passed as
appId, so the console now resolves them itself:$lib/helpers/oauth2-cimd.tswithgetOAuth2App(appId): plain IDs go throughsdk.forConsole.apps.get()as before; URL-shaped client IDs (https, or http on loopback for local dev) are fetched directly from the browser and the RFC 7591 metadata document is mapped ontoModels.App(client_name→name,logo_uri→logoUri,policy_uri/tos_uri→ privacy/terms links, device-code grant →deviceFlow, etc.).client_idmust equal the URL it was fetched from; mismatching or malformed documents are rejected. URI fields are sanitized to http(s) before being rendered insrc/href.apps.get()call sites through the helper: OAuth2 consent page (grant load + already-consented redirect), device flow page, and the account Applications list.Testing
bun run test:unit— newoauth2-cimd.test.tspasses (7 tests)bun run format,bun run linton touched files — cleanbun run check— only pre-existing failure (dompurifytypes inmodal.svelte), unrelated🤖 Generated with Claude Code