Skip to content

test: deflake is_finished assertions in shared request queue mode #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vdusek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: deflake is_finished assertions in shared request queue mode #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/integration/test_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,14 @@ async def test_request_queue_is_finished_and_is_empty(
)

await request_queue_apify.add_request(Request.from_url('http://example.com'))
assert not await request_queue_apify.is_finished()
# `is_finished` reads the queue head, which reflects the newly added request only after propagation, so poll
# until the queue stops reporting itself as finished.
assert not await poll_until_condition(
request_queue_apify.is_finished,
lambda finished: not finished,
timeout=rq_poll_timeout,
backoff_factor=2,
), 'RequestQueue should not be finished after a request is added.'

fetched = await poll_until_condition(
request_queue_apify.fetch_next_request, timeout=rq_poll_timeout, backoff_factor=2
Expand All @@ -1251,9 +1258,12 @@ async def test_request_queue_is_finished_and_is_empty(
assert await poll_until_condition(request_queue_apify.is_empty, timeout=rq_poll_timeout, backoff_factor=2), (
'RequestQueue should be empty because queue does not contain any requests for fetching.'
)
assert not await request_queue_apify.is_finished(), (
'RequestQueue should not be finished unless the request is marked as handled.'
)
assert not await poll_until_condition(
request_queue_apify.is_finished,
lambda finished: not finished,
timeout=rq_poll_timeout,
backoff_factor=2,
), 'RequestQueue should not be finished unless the request is marked as handled.'

await request_queue_apify.mark_request_as_handled(fetched)
assert await poll_until_condition(request_queue_apify.is_empty, timeout=rq_poll_timeout, backoff_factor=2)
Expand Down
Loading