docs: correct stale facts in CLAUDE.md - #1857
Merged
Merged
Conversation
Three claims had drifted away from the repo: - Testing said "JUnit 5 with AssertJ and Mockito". There is no JUnit 5 in this repository at all — parent/pom.xml declares junit:junit:4.13.2 and there are zero org.junit.jupiter imports. ~114 classes extend XWorkTestCase (JUnit 3 style, testXxx() naming) and ~210 use org.junit.Test. This mattered: a Jupiter @test added to an XWorkTestCase subclass is silently never collected, so the wrong guidance produced tests that look green because they never ran. - Project Overview pinned "Current version: 7.2.0-SNAPSHOT" while the pom is on 7.4.0-SNAPSHOT. Replaced the hardcoded number with a pointer to the pom plus a note that the -SNAPSHOT value is a placeholder, not the next release number. - Pull Requests said a Jira ticket ID is required, full stop. Doc, build and CI changes take no ticket and use conventional-commit form; recent history is consistently docs:/build(ci):/chore:. Also mentions .claude/skills/ alongside agents and commands. 🤖 Generated by AI Assistant
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while auditing my local project memory for drift; the same three facts had drifted in
CLAUDE.md.Testing section said JUnit 5 (the one that actually bites)
There is no JUnit 5 in this repository:
org.junit.jupiterimportsimport org.junit.Test(JUnit 4)extends XWorkTestCase(JUnit 3 style)parent/pom.xmljunit:junit:4.13.2This is not cosmetic.
XWorkTestCaseextendsjunit.framework.TestCase, so a Jupiter@Testadded to one of its ~114 subclasses is silently never collected — it does not error, the
suite just stays green while the new test never runs. Guidance that says "tests use JUnit 5"
leads straight into that.
The section now states the two coexisting styles, the
testXxx()naming requirement, and thatintroducing Jupiter is a build-infrastructure change deserving its own
WW-ticket.Version was pinned to 7.2.0-SNAPSHOT
The pom is on
7.4.0-SNAPSHOT. Rather than swap one hardcoded number for another that willdrift again, the file now points at the pom and notes that
-SNAPSHOTis a placeholder — therelease version is picked at release time from the semver impact of the accumulated changes.
PR title rule was absolute
It said a Jira ticket ID is required, full stop. Doc/build/CI changes take no ticket and use
conventional-commit form — as recent history does consistently (
docs:,build(ci):,chore:).This PR is itself an example.
Also mentions
.claude/skills/alongside.claude/agents/and.claude/commands/.No ticket: documentation-only change.