HDDS-16224. Wait for the container to be applied before reading it in TestFailureHandlingByClient - #11065
Open
rich7420 wants to merge 1 commit into
Open
HDDS-16224. Wait for the container to be applied before reading it in TestFailureHandlingByClient#11065rich7420 wants to merge 1 commit into
rich7420 wants to merge 1 commit into
Conversation
…andlingByClient testBlockCountOnFailures read each block's container from a fixed pipeline index (block1DNs.get(2) / block2DNs.get(0)). The second block is written to a fresh pipeline allocated after the injected DN failure and commits on a majority of its replicas, so the indexed node may be the lagging replica that has not yet applied the create-container transaction: getContainer(id) returns null and the cast to KeyValueContainer NPEs (testBlockWritesWithDnFailures:220 -> testBlockCountOnFailures:297). Use ClusterContainersUtil.getContainerByID, which returns the container from whichever datanode already has it, instead of a fixed pipeline index.
Contributor
Author
|
cc @ChenSammi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClient
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] TestFailureHandlingByClient.testBlockWritesWithDnFailures:220->testBlockCountOnFailures:297 NullPointer Cannot invoke "org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer.getContainerData()" because the return value of "org.apache.hadoop.ozone.container.common.impl.ContainerSet.getContainer(long)" is null
https://github.com/apache/ozone/actions/runs/32214904390/job/95956901115?pr=11050
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16224
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32262889697/job/96101277155
https://github.com/rich7420/ozone/actions/runs/32262892271