HDDS-16205. Avoid the duplicate list copy in S3MultipartUploadCompleteRequest.getMultipartDataSize - #11064
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-16205. Avoid the duplicate list copy in S3MultipartUploadCompleteRequest.getMultipartDataSize#11064shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
…eRequest.getMultipartDataSize
Contributor
|
@shuan1026 thanks for the patch! |
rich7420
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
S3MultipartUploadCompleteRequest.getMultipartDataSizecallsOmKeyLocationInfoGroup.getLocationList()twice for the same version group per MPU part: once to setpartNumberon each block, and again toaddAllthose same blocks intopartLocationInfos.getLocationList()is documented as expensive: it flatten-copieslocationVersionMap.values()into a brand-newArrayListon every call. SinceOmKeyLocationInfois a mutable object, the second call re-flattens the same data the first call already produced, just to read it once more.Replaces both calls with a single
getLocationLists()walk of the live, uncopiedCollection<List<OmKeyLocationInfo>>view oflocationVersionMap.values(), settingpartNumberand doingaddAllin one pass per inner list. Zero list copies instead of two, sameforEachidiom as before.Same accessor-usage fix already applied in
KeyManagerImpl.refreshPipeline(HDDS-5384),ContainerEndpoint.getBlocks(HDDS-16202), andContainerToKeyMapping.getContainers(HDDS-16204). Behavior and ordering are unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16205
How was this patch tested?
The following test suites passed (16 tests):
Also ran checkstyle.sh and author.sh successfully.