HDDS-16204. Avoid the per-group list copy in ContainerToKeyMapping.getContainers - #11047
Open
shuan1026 wants to merge 3 commits into
Open
HDDS-16204. Avoid the per-group list copy in ContainerToKeyMapping.getContainers#11047shuan1026 wants to merge 3 commits into
shuan1026 wants to merge 3 commits into
Conversation
shuan1026
changed the title
Contributor
|
@shuan1026 Please merge latest master branch to fix the integration test faiure - https://github.com/apache/ozone/actions/runs/32148571598/job/95988286946?pr=11047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Swaps
getLocationList()forgetLocationLists(), which returns the same data as a live, uncopiedCollection<List<OmKeyLocationInfo>>view, adding one nestedforEachlevel to walk the inner lists.Same fix pattern as
OMKeyRequest.sumBlockLengths(HDDS-16183) andContainerEndpoint.getBlocks(HDDS-16202).getLocationLists()itself comes from HDDS-5384.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16204
How was this patch tested?
The following test suite passed (8 tests):
TestContainerToKeyMappingAlso ran
checkstyle.shandauthor.shsuccessfully.