HDDS-16202. Avoid the list copy in ContainerEndpoint.getBlocks - #11038
Merged
Conversation
sravani-revuri
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM.
Now getBlocks uses getLocationLists() instead of flattening and applies the container ID check during iteration.
sodonnel
approved these changes
Aug 20, 2026
sodonnel
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks for improving this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerEndpoint.getBlockscalledOmKeyLocationInfoGroup.getLocationList()and thenstream().filter().collect(toList())on the result, allocating two throwaway lists per key just to walk each block once.getLocationList()is documented as expensive: it flattenslocationVersionMap.values()into a brand-newListon every call, instead of the O(1)getLocationLists()accessor.This PR rewrites
getBlocksto iterategetLocationLists()directly with a nested loop and an inline containerID check, removing both list allocations. Same pattern asOMKeyRequest.sumBlockLengths(HDDS-16183)and
KeyManagerImpl.refreshPipeline(HDDS-5384). Output ordering and contents are unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16202
How was this patch tested?
Existing tests cover
getBlocksthrough the ReconGET /api/v1/containers/:id/keysendpoint, including block-id and pagination assertions.The following test suite passed (2 tests):
TestContainerEndpoint#testGetKeysForContainerTestContainerEndpoint#testGetKeysForContainerWithPrevKeyAlso ran
checkstyle.shandauthor.shsuccessfully.