Skip to content

HDDS-16193. Clean up ScmClient - #11035

Open
echonesis wants to merge 1 commit into
apache:masterfrom
echonesis:test-HDDS-16193
Open

HDDS-16193. Clean up ScmClient#11035
echonesis wants to merge 1 commit into
apache:masterfrom
echonesis:test-HDDS-16193

Conversation

@echonesis

@echonesis echonesis commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

ScmClient is an internal interface that contains several deprecated or unused methods.

This PR:

  • removes the deprecated createContainer overload that accepts replication type and factor separately;
  • removes unused container creation, deletion, reading, and size methods;
  • removes the corresponding implementations and unused configuration fields from ContainerOperationClient;
  • updates existing test callers to use ReplicationConfig explicitly.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-16193

How was this patch tested?

Local Test

# The Non-HA integration test suite was run with a clean reactor build
mvn -pl :ozone-integration-test -am \
    clean test \
    -Dtest=TestOzoneIntegrationNonHA \
    -Dsurefire.failIfNoSpecifiedTests=false -DskipShade -DskipRecon -DskipDocs -Dscan=false

# The updated container balancer test was also run directly
mvn -pl :ozone-integration-test test \
    -Dtest=TestContainerBalancerOperations \
    -DskipShade -DskipRecon -DskipDocs -Dscan=false

GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32006995899

Generated-by: Codex (GPT-5)

@szetszwo szetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants