HDDS-16196. Bump Apache Ratis to 3.3.0 - #11032
Open
amaliujia wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
R: @szetszwo |
amaliujia
commented
Aug 17, 2026
| } | ||
| final MD5Hash md5 = MD5FileUtil.computeAndSaveMd5ForFile(snapshotFile); | ||
| final FileInfo fileInfo = new FileInfo(snapshotFile.toPath(), md5); | ||
| storage.updateLatestSnapshot(new SingleFileSnapshotInfo(fileInfo, ti)); |
Contributor
Author
There was a problem hiding this comment.
Maybe we should not do this but just update the test case? Maybe related to https://issues.apache.org/jira/browse/RATIS-244.
Without these a few lines of code I saw a mis-match snapshot count in TestContainerStateMachine.
peterxcli
self-requested a review
August 17, 2026 11:25
Contributor
@spacemonkd , could you take a look if the failure is related to RATIS-244? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump Apache Ratis to 3.3.0.
TestContainerStateMachinewas failing for wrong snapshot counts which might be related to https://issues.apache.org/jira/browse/RATIS-244.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16196
How was this patch tested?
Existing tests