HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets - #11016
Open
len548 wants to merge 4 commits into
Open
HDDS-16163. Fix TrashOzoneFileSystem error handling on LEGACY buckets#11016len548 wants to merge 4 commits into
len548 wants to merge 4 commits into
Conversation
sadanand48
approved these changes
Aug 17, 2026
sadanand48
left a comment
Contributor
There was a problem hiding this comment.
Thanks @len548 for the patch, LGTM, pending CI
Contributor
|
@len548 Looks like there are merge conflicts. could you please resolve them? |
Contributor
Author
|
Thank you @sadanand48 for pointing out the merge conflict. I kept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
On legacy buckets (non-FSO path),
delete()andrename()inTrashOzoneFileSystemcould report success even when the underlying OM write failed:RenameIterator/DeleteIteratorswallowed errors —submitRequest()failures were caught, logged, and iteration continued as if nothing failed.delete()/rename()always returned true, even wheniterate()returned false.createOMRequest()failed, a null request could be passed tosubmitRequest()or fail without propagating failure to the caller.This fix propagates these delete/rename failures from the LEGACY trash iterator path instead of always returning true.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16163
How was this patch tested?
Add UT written by Cursor with Composer 2.5 model