HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version - #11006
Draft
errose28 wants to merge 7 commits into
Draft
HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version#11006errose28 wants to merge 7 commits into
errose28 wants to merge 7 commits into
Conversation
…or all components (cherry picked from commit 1718018c67f8535f701f4493fd7e8d73478e5d61)
errose28
added
the
zdu
Contributor
Author
|
Link to relevant comments which I'll fix here: |
* HDDS-14496-zdu: HDDS-16153. DatanodeDetails should use HDDSVersion instead of int (apache#10994) HDDS-15549. Recon's INITIAL_VERSION should not have an upgrade action (apache#10935) HDDS-14753. Do not prematurely serialize client version (apache#10936) HDDS-15885. SCM should validate software versions of peers before accepting finalize command (apache#10783) HDDS-15641. SCM should send write pipeline version with DatanodeDetails on block allocation (apache#10878) Conflicts: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/protocol/TestDatanodeDetails.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockDataStreamOutput.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java
Contributor
Author
|
This is ready for review, just leaving as draft until CI on the latest commit goes through my fork. Thanks @ss77892 for the initial comments, they've been addressed here. |
sodonnel
approved these changes
Aug 20, 2026
sodonnel
left a comment
sodonnel
left a comment
Contributor
There was a problem hiding this comment.
LGTM if we get green CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DatanodeDetails#currentVersionis passed from Datanodes through SCM to clients to indicate the Datanode's server version. Once ZDU is finalized, this value should be the apparent version of the Datanode instead of a static software version. A new abstract method is added toComponentVersionManagerto handle this and implemented for every component in this PR. On Datanodes, this method is called in the register and heartbeat endpoint tasks to provide SCM with the most up to date current version.Additionally,
DatanodeDetails#currentVersionis currently persisted into the Datanode'sdatanode.idyaml file, but never used. When Datanodes finalize, the current version they report to clients will increase, and this location will become stale. To keep it from diverging we should stop persisting this value in thedatanode.idfile.What is the link to the Apache JIRA
HDDS-16154
How was this patch tested?