[5.0.x] Update Partial Rendering - #1053
Open
volosied wants to merge 2 commits into
Open
Conversation
The jakarta.faces.partial.render / .execute request parameters (and the jakarta.faces.source parameter) were split into client ids without any limit on the number or length of the ids. PartialVisitContext then retained one prefix substring per naming-container separator of each id, so a single very long id was expensive to process. Cap the parsed list to 256 ids of at most 256 chars each, collapse duplicates, and bound the naming-container depth registered per id in PartialVisitContext so that work stays linear in the id length. Update Partial Context comments
UIViewRoot.encodeChildren triggered partial rendering whenever PartialViewContext.isAjaxRequest() was true, even for a request without a jakarta.faces.ViewState. Such a request is not a postback and is not restoring a view, so additionally require FacesContext.isPostback() before partial-rendering; otherwise fall back to a normal render. Update UIViewRoot comments
Member
|
Please not the Postback/isAjaxRequest change, it breaks the spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.