Fix the doubled dash in the download page filenames - #440
Merged
Conversation
The three link labels in the Files table read "maven-wrapper--<version>", with a spurious second dash. Only the labels were affected; the hrefs already pointed at the correct maven-wrapper-<version>-source-release.zip, so the links worked but showed users a filename that does not exist. Confirmed against https://downloads.apache.org/maven/wrapper/, which currently lists maven-wrapper-3.3.4-source-release.zip and its .asc and .sha512 companions. The literal "maven-wrapper" prefix is left as is: this project's artifactId is maven-wrapper-parent, so ${project.artifactId} would not produce the released filename. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three link labels in the Files table on the download page read
maven-wrapper--<version>-source-release.zip, with a spurious second dash.Only the labels were affected. The
hrefs already pointed at the correctmaven-wrapper-<version>-source-release.zip, so the links worked — but they displayed a filename that does not exist, which is confusing for anyone verifying a download by name.Confirmed against https://downloads.apache.org/maven/wrapper/, which currently lists:
The literal
maven-wrapperprefix is deliberately left as is: this project'sartifactIdismaven-wrapper-parent, so${project.artifactId}would not produce the released filename.Found while surveying
src/site/xdoc/download.xml.vmacross the Maven estate — this typo is unique to this repository.Draft until CI is green.