test(grails-data-graphql): add missing test coverage across the module - #16201
Open
borinquenkid wants to merge 1 commit into
Open
test(grails-data-graphql): add missing test coverage across the module#16201borinquenkid wants to merge 1 commit into
borinquenkid wants to merge 1 commit into
Conversation
…bled spec Removes MongoSchemaSpec.groovy.disabled, an orphaned test for MongoDB support the module no longer depends on. Adds Spock specs closing coverage gaps identified across the module: all untested scalar Coercing implementations (Currency, Date, SqlDate, Time, TimeZone, Timestamp, URI, URL, UUID, and the JSR-310 date/time coercions), CountEntityDataFetcher, PaginatedEntityDataFetcher, PersistentPropertyDataFetcher, ClosureDataFetchingEnvironment, CachingGraphQLResponseHandler, KeyClassQuery, DataBinderNotFoundException, and DataFetcherNotFoundException. Renames the existing MutationInterceptorInvokerSpec/ QueryInterceptorInvokerSpec to Custom*InterceptorInvokerSpec since they actually exercised the Custom*InterceptorInvoker classes, and adds specs for the real MutationInterceptorInvoker/ QueryInterceptorInvoker. Also extends DefaultGraphQLErrorsResponseHandlerSpec to cover the LocaleAwareContext branch of getLocale(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 23, 2026
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.1.x #16201 +/- ##
=============================================
Coverage 53.4149% 53.4149%
Complexity 19459 19459
=============================================
Files 2081 2081
Lines 98993 98993
Branches 17361 17361
=============================================
Hits 52877 52877
Misses 38566 38566
Partials 7550 7550 🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: 36b7716 Learn more about TestLens at testlens.app/docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grails-data-graphql-core: binding, fetcher, fetcher/interceptor, response, and the scalar coercion package (including all jsr310 date/time coercions).MongoSchemaSpec.groovy.disabled).This is the foundation commit for a series of smaller cleanup PRs that follow (each fixes IntelliJ-flagged issues in one package and stacks on this one):
Test plan
./gradlew :grails-data-graphql-core:test :grails-data-graphql:test :grails-data-graphql-core:codeStyle :grails-data-graphql:codeStylepasses🤖 Generated with Claude Code