[rpc] Fix RequestChannel backpressure race - #4024
Open
fxbing wants to merge 1 commit into
Open
Conversation
- Reconcile queue thresholds and backpressure state atomically. - Add deterministic race and zero-threshold regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Concurrent queue updates can pass the pause or resume pre-check before another thread changes the backpressure state. The stale operation can then acquire the lock and leave
autoReadinconsistent with the current queue size.Brief change log
Tests
./mvnw -pl fluss-rpc -Dtest=RequestChannelTest test— 5 tests passed../mvnw -pl fluss-rpc verify— 76 unit tests and 12 integration tests passed../mvnw -pl fluss-rpc spotless:checkandgit diff --check.API and Format
No public API, configuration, RPC, or storage-format changes.
Documentation
No documentation changes; this is an internal backpressure concurrency fix.
Generative AI disclosure