Skip to content

Add NULL check during restoreVM operation when host is removed - #13779

Open
nvazquez wants to merge 2 commits into
apache:4.22from
shapeblue:422-nullcheck-restorevm
Open

Add NULL check during restoreVM operation when host is removed#13779
nvazquez wants to merge 2 commits into
apache:4.22from
shapeblue:422-nullcheck-restorevm

Conversation

@nvazquez

@nvazquez nvazquez commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR addresses a fix for the following use case:

  • Create VM
  • Start VM
  • Stop VM
  • Delete Host where VM was started
  • Restore VM -> Restore VM command failed, VM ended up with two ROOT volumes, one of them is in Allocated state
  • Expected result: VM restored (with new template)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sachindoddaguni and others added 2 commits August 3, 2026 15:37
…e#571)

* Add NULL check during restore VM operation when host is not available/removed

* fix line ending pre commit failure

* update logging with details of removed host and vm

---------

Co-authored-by: Sachin R Doddaguni <s_rudrappadoddagu@apple.com>
(cherry picked from commit 1dbda12ccdca1aaf86ef8f9b185986c9d22b567e)
@nvazquez nvazquez added this to the 4.22.2 milestone Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants