Update auth.md - #3652
Conversation
Console.log had the wrong logged value.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
The fix is correct: the callback parameter in scope is token, and the original line referenced the type name string, which is not a value in this example. One-line change, verified against the current head.
@saadlalam You'll need to sign the Contributor License Agreement (CLA) first to get this merged.
armando-navarro
added
comp: docs
The idToken example's subscription logged `string`, a type name rather than a value in that scope, so the snippet would not compile if copied. Log the `token` parameter the callback receives, matching the neighboring authState example. Also correct the comment on the line above, copied from the authState example, which referred to a user rather than the token this example streams. Reland of #3652 by saadlalam, whose fix was correct but could not be merged because the CLA check never cleared on that branch.
|
Thanks for catching this and for the fix, @saadlalam. The change is correct: the callback parameter in scope is The one thing blocking a merge here was the CLA check, which never cleared on this branch. Rather than leave a good fix stranded, I've applied your correction in #3728 and credited you there. I'm closing this in favor of that PR, but the fix is yours. Thanks again for taking the time to report and fix it. |
2 participants
Console.log had the wrong logged value.
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Code sample