fix(@schematics/angular): import UrlSegment instead of subPath in guard generator - #33807
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@schematics/angular): import UrlSegment instead of subPath in guard generator#33807alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
alan-agius4
added
action: review
alan-agius4
marked this pull request as ready for review
August 7, 2026 15:26
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Angular guard schematic to import UrlSegment instead of subPath when generating a guard that implements CanMatch. The corresponding unit tests have also been updated to reflect this change. There are no review comments, and I have no additional feedback to provide.
…rd generator When generating class-based `CanMatch` guards (`ng g guard --implements=CanMatch --no-functional`), the guard implementation template defines `canMatch(route: Route, segments: UrlSegment[])`. Previously, the schematic added `'subPath'` instead of `'UrlSegment'` to `@angular/router` named imports. Because `@angular/router` does not export `subPath`, this generated code with broken imports (`Module '"@angular/router"' has no exported member 'subPath'`) while leaving `UrlSegment` unimported (`Cannot find name 'UrlSegment'`). This change ensures `UrlSegment` is imported when generating `CanMatch` guards.
alan-agius4
force-pushed
the
fix-schematic-guard-urlsegment
branch
from
August 7, 2026 15:27
60bd0e5 to
ec25af5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating class-based
CanMatchguards (ng g guard --implements=CanMatch --no-functional), the guard implementation template definescanMatch(route: Route, segments: UrlSegment[]).Previously, the schematic added
'subPath'instead of'UrlSegment'to@angular/routernamed imports. Because@angular/routerdoes not exportsubPath, this generated code with broken imports (Module '"@angular/router"' has no exported member 'subPath') while leavingUrlSegmentunimported (Cannot find name 'UrlSegment').This change ensures
UrlSegmentis imported when generatingCanMatchguards.