fix(@angular/cli): mitigate package self-referencing in local CLI resolution - #33740
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@angular/cli): mitigate package self-referencing in local CLI resolution#33740alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…olution Instead of resolving `@angular/cli` when bootstrapping the local CLI, we resolve `@angular/cli/lib/cli/index.js`. This ensures that Node.js only resolves the local CLI if the specific directory structure exists inside `node_modules`, preventing unintended package self-reference resolutions outside of `node_modules`.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Collaborator
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the CLI initialization in packages/angular/cli/lib/init.ts to resolve @angular/cli/lib/cli/index.js instead of @angular/cli. This ensures that Node.js only resolves the path if the specific folder structure exists in node_modules, preventing self-referencing package resolution issues. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of resolving
@angular/cliwhen bootstrapping the local CLI, we resolve@angular/cli/lib/cli/index.js. This ensures that Node.js only resolves the local CLI if the specific directory structure exists insidenode_modules, preventing unintended package self-reference resolutions outside ofnode_modules.