test(ci): add command validator regression coverage - #443
Open
ayobamiseun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-commands.jscurrently runs against the repository's eight valid command triples in CI. That proves the catalog passes, but not that the validator rejects the invalid states it exists to catch.This PR adds a fixture-driven
node:testsuite that runs the real CLI inside temporary repositories and asserts its public exit codes and diagnostics. It then runs that suite in the existing command-validation CI job.Coverage added
Six regression cases cover the validator's main contracts:
plantoplanningstem mappingThe passing stem-mapping fixture also uses single-quoted TOML, preserving coverage for that supported syntax.
Implementation
validate-commands.jsinto a fresh temporary repository for each test scenario.CI
The existing
validate-commandsjob now runs:This keeps the real-catalog gate and the validator self-tests together.
Verification
node --test scripts/validate-commands-test.js- 6/6 passnode --test scripts/run-evals-test.js scripts/validate-commands-test.js- 18/18 passnode scripts/validate-commands.js- 8 commands, 0 errorsnode scripts/validate-skills.js- 24 skills, 0 errors, 0 warningsnode scripts/run-evals.js- 124 checks passed, 0 errors, 0 warnings; rank-1 86%git diff --check upstream/main...HEAD- clean