Prefix the package branches with their package number - #18
Merged
Conversation
The per-package branches carried the topic alone (odata, rap, mime), so the abapGit branch dropdown listed them alphabetically - unrelated to the reading order the packages have in the README. Every branch now carries its package number (01-odata, 02-smart-controls, ...), so the dropdown sorts the same way the package table does. Also fixes two leftovers from the samples-ext rename that this touches: the push step of create-package-branches was gated on the old repository name, so it never pushed a branch in samples-stack, and the generated branch READMEs linked back to the old repository. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ACqzsYFC5dRLvi1eMnnbtZ
The repository description, the overview class description and the shell title of the overview app still carried the old repository name, so an installed system showed samples-ext while every link pointed at samples-stack. Text only - no ABAP logic is touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ACqzsYFC5dRLvi1eMnnbtZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-package branches carried the topic alone, so the abapGit branch dropdown listed them alphabetically —
amc-apc,business-events,launchpad, … — which has nothing to do with the reading order the packages have in the README. Every branch now carries its package number, so the dropdown sorts the same way the package table does.odata01-odatasmart-controls02-smart-controlsrap03-raprap-draft04-rap-draftbusiness-events05-business-eventsstateful-locks06-stateful-locksamc-apc07-amc-apcmime08-mimelaunchpad09-launchpadWhat changed
.github/packages.json— the sourcecreate-package-branchesbuilds the branches fromREADME.md— the branch table, plus one sentence saying what the number meanssrc/01–src/09/README.md— the Branch: line of each packageTwo leftovers from the samples-ext rename
Both sit in the path this change takes, and the first one would have made it a no-op:
create-package-branches.yaml— the push step was gated ongithub.repository == 'abap2UI5/samples-ext', so it never pushed a branch insamples-stack. The nine branches currently on GitHub are therefore stands from before the rename, and the numbered ones would never have been created.build-package-branch.mjs,src/package.devc.xml,z2ui5_cl_smpe_app_00— the generated branch READMEs linked back to the old repository, and the package description, the class description and the shell title of the overview app still readsamples-exton an installed system. Text only, no ABAP logic touched.Checks
check-overview.mjspasses, andbuild-package-branch.mjs 03-rapwas run against a copy of the tree — it builds the reduced tree correctly and rejects the old names.abaplintcould not run in this environment (npm registry unreachable) and runs in CI.After the merge
The nine old, unnumbered branches stay behind —
create-package-branchesonly creates the new ones, it does not delete what it no longer knows about. They should be deleted, otherwise the abapGit dropdown shows 18 entries, half of them stale.Generated by Claude Code