feat(server): allow injecting custom A2AHttpClient for push notificat… - #1029
Open
malladinagarjuna2 wants to merge 2 commits into
Open
feat(server): allow injecting custom A2AHttpClient for push notificat…#1029malladinagarjuna2 wants to merge 2 commits into
malladinagarjuna2 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the ability to plug in a custom
A2AHttpClientimplementation on the server side by natively supporting CDI injection in theBasePushNotificationSender.Fixes #135
The Problem
When server-related code was extracted from
coreintoserver-common(in #129), the Push Notification sender was modified to hardcode its usage ofJdkA2AHttpClientviaA2AHttpClientFactory.create(). This prevented developers from replacing the underlying HTTP client on the server side (e.g. replacing the JDK client with the Vert.x HTTP client, or providing a custom client with specific interceptors/auth mechanisms).The Solution
Instance<A2AHttpClient>to CDI Constructor: The@Injectconstructor inBasePushNotificationSendernow accepts anInstance<A2AHttpClient>.A2AHttpClientbean available (!httpClientInstance.isUnsatisfied()), it will use it. Otherwise, it gracefully falls back toA2AHttpClientFactory.create(), ensuring 100% backwards compatibility for users who don't provide a custom bean.