fix(ci): restore coverage reporting after runner label migration - #248
Merged
Conversation
PR #246 renamed the test matrix runners from `ubuntu-latest`/`windows-latest` to `uipath-ubuntu-latest`/`uipath-windows-latest`, but the step conditions still compared against the old labels. `matrix.os == 'ubuntu-latest'` can never be true now, so: - "Run tests with coverage" was skipped on every job - no coverage.xml artifact was uploaded - the SonarCloud job's download silently missed it (continue-on-error) - SonarCloud has reported 0% coverage since 2026-08-06 CI stayed green because the inverse condition became always-true, so plain pytest ran on all six combinations. Use endsWith(matrix.os, 'ubuntu-latest') so the conditions keep matching if the runner prefix changes again. Tests themselves are unaffected: 203 pass with 98.39% coverage locally on this commit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Restores CI coverage reporting by fixing GitHub Actions step conditions that stopped matching after runner labels were migrated to uipath-*, ensuring a single (Ubuntu + Python 3.13) matrix entry generates and uploads coverage artifacts for SonarCloud.
Changes:
- Update
if:conditions to useendsWith(matrix.os, 'ubuntu-latest')so they matchuipath-ubuntu-latest. - Re-enable the “coverage” test run and the coverage HTML/XML artifact uploads for the intended single matrix combination.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
edis-uipath
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SonarCloud has reported 0% coverage on
mainsince 2026-08-06, which re-opened the MER code-coverage KPI (PRODEV-612).PR #246 renamed the test matrix runners:
but the step conditions still compare against the old labels:
So on every run since:
Run tests with coverage→ skippedUpload coverage XML report→ skipped (no artifact)Download coveragein thesonarcloudjob → misses it, swallowed bycontinue-on-error: trueCI stayed ✅ green because the inverse condition
!(...)became always-true, so plainpytestran on all six combinations.Evidence from the Aug-6 run (
test / Test (3.13, uipath-ubuntu-latest)):Fix
Use
endsWith(matrix.os, 'ubuntu-latest')so the conditions match both the currentuipath-prefixed labels and any future prefix change.Exactly one job (
uipath-ubuntu-latest+ Python 3.13) produces coverage again — same as the original design.Verification
Tests are unaffected — only the CI plumbing broke. On this commit, locally:
203 passedAfter merge, the SonarCloud analysis on
mainshould return to ~98%.🤖 Generated with Claude Code