bugfix(saveload): Transfer the dock approach position bone count - #3151
Draft
bobtista wants to merge 2 commits into
Draft
bugfix(saveload): Transfer the dock approach position bone count#3151bobtista wants to merge 2 commits into
bobtista wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_numberApproachPositionBonesis not written to the save. It starts at-1and is only assigned insideloadDockPositions(), which every call site guards withif( m_positionsLoaded == FALSE ). Sincem_positionsLoadedis saved, the guard is already satisfied on load, the count is never recomputed, and it stays at-1.computeApproachPositiontests it against0to decide whether a structure with no waiting bones should bias its approach point toward the caller.-1fails that test, so the bias is silently dropped and every docker is routed to the structure centre. That covers structures with noDockWaitingbones,KINDOF_IGNORE_DOCKING_BONESstructures, and dynamic approach docks, which are forced to zero bones.Now the count travels with the flag that suppresses its recomputation, from version 2.
Measured by saving on the frame a dock finishes loading its positions, then reading the count back, with the loaded flag as a control:
The loaded flag round trips in both rows, so the record is written and read either way; version 1 is byte for byte the old behaviour, which is what keeps existing saves readable.
Todo: