refactor(network): Sort command list fast path by sort number

[CryoTheRenegade]

• Closes NetCommandList::addMessage sorts messages by id using different functions #2795

Changed the cached NetCommandList::addMessage insertion path to use getSortNumber(), matching the full list traversal.

For normal commands this is equivalent to getID(). ACK commands override it with the ID of the command being acknowledged, so using it consistently prevents incorrect ACK ordering.

[Skyaero42]

Starting to look better, but still a few points of attention and some formatting

[Caball009]

I'm a bit concerned this may affect retail compatibility. Please test this change in a multiplayer match. You can use two local instances, one with the change and one without.

[CryoTheRenegade]

I'm a bit concerned this may affect retail compatibility. Please test this change in a multiplayer match. You can use two local instances, one with the change and one without.

Tested with latest weekly as control, no issues seen (had 2 instances of tracy in the background and nothing weird happened, but im not very good at playing against myself so i didnt stress it out too much :/)

[xezon]

The title says that this is a bug fix. What is the bug that can be observed in the game before this fix?

[CryoTheRenegade]

The cached fast path could order network commands differently from the full scan. Peers can then consume commands in different orders, causing multiplayer desync. This makes both paths use the same ordering: type, player, then sort number

[Caball009]

Would you mind writing test code that forces a mismatch because of this bug? FWIW I did something similar for a similar PR here: https://www.github.com/TheSuperHackers/GeneralsGameCode/pull/2736/changes/f386e5fb030acf148f7d038c6c2a09808ab7425d

[CryoTheRenegade]

Added test code (https://github.com/CryoTheRenegade/GeneralsGameCode/tree/test/netcommandlist-order-repro)

Core/Tools/Scratch/reproduce_netcommandlist_order.cpp is a self-contained harness that mirrors NetCommandList::addMessage with a toggle between the pre-fix fast-path key (getID()) and the fix (getSortNumber()), brute-forcing arrival orders. Over 20000 randomized cases the final command order diverges in ~4% of them.

The game catches this live and runs the correct order, but we should not be relying on a fallback when we can get it right the first time

[xezon]

Code is difficult to read and understand.

[xezon]

This change is now a mix of refactor and fix; is that right? If yes, can we split it into 2 commits or 2 pull requests to merge to main?

[CryoTheRenegade]

Yes, the PR now includes the fix and some cleanup added during review. I kept one PR and split it into two commits so each part is clear.

[xezon]

Yes, the PR now includes the fix and some cleanup added during review. I kept one PR and split it into two commits so each part is clear.

Ok that is good. Please add pull id to commit titles

[CryoTheRenegade]

Done.