Fix pointer style crash during early theme changes - #6682
Open
deepakganesh78 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6360
Reproduction
A minimal app that sets
pointer: defaultin CSS and switches totextual-lightin__init__crashes during startup because CSS is refreshed before any screen has been pushed.Root cause
Updating a pointer style calls
obj.node.screen.update_pointer_shape(). For theAppnode during early theme application,App.screenraisesScreenStackErrorbecause the screen stack is still empty; the pointer-style code only handledNoScreen.Fix
Treat
ScreenStackErrorlikeNoScreenfor pointer updates, deferring pointer-shape refresh until a screen exists. This preserves existing pointer updates once the app is mounted.Compatibility notes
This only suppresses an early pointer-shape refresh when no active screen exists. Existing validation and mounted pointer-style behavior are unchanged.
Validation
python -m pytest tests\test_app.py::test_app_pointer_style_with_theme_before_screen_stack tests\test_app.py::test_pointer_shape -q→ 2 passedtests\test_app.py::test_app_pointer_style_with_theme_before_screen_stackfails withScreenStackError: No screens on stack.python -m pytest tests --ignore=tests\snapshot_tests -q→ 3013 passed, 1 skipped, 4 xfailed