Handle Windows PermissionDenied during storage footprint sync sweep - #24
Merged
Conversation
Co-authored-by: argahsuknesib <87450516+argahsuknesib@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Test Suite (windows-latest, stable)
Handle Windows Aug 20, 2026
PermissionDenied during storage footprint sync sweep
argahsuknesib
marked this pull request as ready for review
August 20, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Test Suite (windows-latest, stable)job failed inpaper_bench::storage_footprintbecause benchmark runs errored withOs { code: 5, kind: PermissionDenied, message: "Access is denied." }. The failure came from treating allsync_all()errors as fatal while traversing benchmark store files on Windows.Root cause
sync_tree()unconditionally propagatedfile.sync_all()errors, including Windows-specific permission denials on files created/managed by the benchmarked storage engines.Targeted change
src/paper_bench/storage_footprint.rssosync_tree()ignoresstd::io::ErrorKind::PermissionDeniedfor filesync_all()calls.Behavioral impact