Skip to content

Handle Windows PermissionDenied during storage footprint sync sweep - #24

Merged
argahsuknesib merged 2 commits into
mainfrom
copilot/fix-github-actions-job
Aug 20, 2026
Merged

Handle Windows PermissionDenied during storage footprint sync sweep#24
argahsuknesib merged 2 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The Test Suite (windows-latest, stable) job failed in paper_bench::storage_footprint because benchmark runs errored with Os { code: 5, kind: PermissionDenied, message: "Access is denied." }. The failure came from treating all sync_all() errors as fatal while traversing benchmark store files on Windows.

  • Root cause

    • sync_tree() unconditionally propagated file.sync_all() errors, including Windows-specific permission denials on files created/managed by the benchmarked storage engines.
  • Targeted change

    • Updated src/paper_bench/storage_footprint.rs so sync_tree() ignores std::io::ErrorKind::PermissionDenied for file sync_all() calls.
    • Preserved existing behavior for all other error kinds (still fail fast).
  • Behavioral impact

    • Benchmark storage footprint tests no longer fail due to non-actionable Windows permission denials during fsync traversal.
    • Real I/O failures remain visible and continue to abort the run.
let file = File::open(&path)?;
if let Err(err) = file.sync_all() {
    if err.kind() != std::io::ErrorKind::PermissionDenied {
        return Err(err.into());
    }
}

Co-authored-by: argahsuknesib <87450516+argahsuknesib@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Test Suite (windows-latest, stable) Handle Windows PermissionDenied during storage footprint sync sweep Aug 20, 2026
Copilot AI requested a review from argahsuknesib August 20, 2026 11:55
@argahsuknesib
argahsuknesib marked this pull request as ready for review August 20, 2026 11:58
@argahsuknesib
argahsuknesib merged commit b6a0cf2 into main Aug 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants