Fix skipping punctuation in comments - #77
Open
tmaxxdd wants to merge 3 commits into
Open
Conversation
jpietruch
reviewed
Aug 10, 2026
jpietruch
reviewed
Aug 10, 2026
Collaborator
There was a problem hiding this comment.
Looks like PunctuationLocator doesn't distinguish between comments, multiline comments, or strings - it just accepts ignored ranges.
Maybe the tests here could be more generic and just cover cases such as:
- ignores punctuation inside an ignored range
- returns punctuation outside an ignored range
- handles multiple ignored ranges
- handles range boundaries correctly
The comment/string-specific cases could live in CodeAnalyzerTest, where those ranges are actually created and combined.
Let me know what you think.
Member
Author
There was a problem hiding this comment.
Very good point, you're right the knowledge about system shouldn't be written in small logic part (locator)
jakub-pietruch-solid
previously approved these changes
Aug 13, 2026
jpietruch
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.