chore(ci): repin the shared workflow to the stable-check-context revision - #13
Open
h4x0r wants to merge 1 commit into
Open
chore(ci): repin the shared workflow to the stable-check-context revision#13h4x0r wants to merge 1 commit into
h4x0r wants to merge 1 commit into
Conversation
…sion Picks up SecurityRonin/fleet-ci#9, which fixes two things that only bite when you try to REQUIRE a check context. This repo is the one that exhibited the first defect. It passes `coverage-gate: "off"` deliberately -- it gates on FUNCTIONS, which no input to the shared workflow expresses -- and a skipped job publishes its `name:` EXPRESSION rather than the evaluated value. So every run on main reported a check literally named: ci / inputs.coverage-gate == 'floor'\n && format('Coverage (FLOOR {0}% ... with the newlines embedded in the name. The job name is now the constant `Coverage`. Second, the workflow now publishes an aggregate `All checks` job that needs all twelve others. The matrix jobs cannot serve as required contexts because GitHub appends the matrix values -- this repo publishes `MSRV (sqlite-core, 1.80)`, `MSRV (sqlite4n6, 1.96)` and three `Test (<os>)` contexts, all of which move when a crate is added or a floor is raised. `ci / All checks` does not move. Repin only; no behaviour change to the gates themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pilot repin for fleet-ci#9.
This repo is the positive control for the first defect: it passes
coverage-gate: "off"on purpose, and a skipped job publishes itsname:expression instead of the evaluated value. Every run onmaintherefore reported one check whose name was the raw ternary source, newlines and all.Two things to confirm on this PR's checks:
ci / Coverageappears (skipped), and the expression-named check is gone.ci / All checksappears and is green — the aggregate that can actually be required, sinceMSRV (sqlite-core, 1.80)/Test (ubuntu-latest)and friends move whenever a crate is added or a floor changes.Repin only; no gate behaviour changes.