Skip to content

Remove unused owned variable and stale comment in FieldSerializer::Serialize - #364

Closed
jacobmerson with Copilot wants to merge 2 commits into
developfrom
copilot/fix-review-comment-362
Closed

Remove unused owned variable and stale comment in FieldSerializer::Serialize#364
jacobmerson with Copilot wants to merge 2 commits into
developfrom
copilot/fix-review-comment-362

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown

This PR addresses the linked review comment only: FieldSerializer::Serialize fetched owned without using it, and the adjacent comment no longer matched the implementation.
The change removes the dead local and aligns the comment with permutation-driven serialization.

  • Scope

    • Updated only src/pcms/coupler/field_serializer.h in FieldSerializer::Serialize.
  • Code cleanup

    • Removed unused local:
      auto owned = layout.GetOwnedHost();
  • Comment accuracy

    • Reworded the exchange-plan comment to reference only permutation[i] (the actual indexing used by the loop), removing stale owned[i] wording.
// Before
auto owned = layout.GetOwnedHost();
// The exchange plan is per DOF holder: owned[i] and permutation[i] are ...

// After
// The exchange plan is per DOF holder: permutation[i] is indexed by holder.

Co-authored-by: jacobmerson <2366140+jacobmerson@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code following review comment in PR #362 Remove unused owned variable and stale comment in FieldSerializer::Serialize Aug 20, 2026
Copilot AI requested a review from jacobmerson August 20, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants