Remove unused owned variable and stale comment in FieldSerializer::Serialize - #364
Closed
jacobmerson with Copilot wants to merge 2 commits into
Closed
Remove unused owned variable and stale comment in FieldSerializer::Serialize#364jacobmerson with Copilot wants to merge 2 commits into
owned variable and stale comment in FieldSerializer::Serialize#364jacobmerson with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: jacobmerson <2366140+jacobmerson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code following review comment in PR #362
Remove unused Aug 20, 2026
owned variable and stale comment in FieldSerializer::Serialize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the linked review comment only:
FieldSerializer::Serializefetchedownedwithout using it, and the adjacent comment no longer matched the implementation.The change removes the dead local and aligns the comment with permutation-driven serialization.
Scope
src/pcms/coupler/field_serializer.hinFieldSerializer::Serialize.Code cleanup
auto owned = layout.GetOwnedHost();Comment accuracy
permutation[i](the actual indexing used by the loop), removing staleowned[i]wording.