Skip to content

Add ControlledInput RN library - #1

Merged
ipakhomov merged 20 commits into
mainfrom
86c6wprt8-add-lib
Apr 22, 2026
Merged

Add ControlledInput RN library#1
ipakhomov merged 20 commits into
mainfrom
86c6wprt8-add-lib

Conversation

@veliseev93

@veliseev93 veliseev93 commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@veliseev93
veliseev93 requested a review from ipakhomov April 8, 2026 09:05
ipakhomov
ipakhomov approved these changes Apr 18, 2026
View reviewed changes

@ipakhomov ipakhomov left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veliseev93 looks really good!
Please find my suggestions below.

ipakhomov
ipakhomov requested changes Apr 19, 2026
View reviewed changes

@ipakhomov ipakhomov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veliseev93 looks really good!
Please find my suggestions below.

Comment thread android/src/main/java/com/controlledinput/ControlledInputViewManager.kt Outdated
Comment thread ios/RNControlledInput.swift Outdated
Comment thread src/ControlledInputViewNativeComponent.ts Outdated
Comment thread src/ControlledInputViewNativeComponent.ts
Comment thread src/ControlledInputViewNativeComponent.ts
ipakhomov
ipakhomov requested changes Apr 19, 2026
View reviewed changes

@ipakhomov ipakhomov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veliseev93 looks really good!
Please find my suggestions below.

@ipakhomov ipakhomov assigned veliseev93 and unassigned ipakhomov Apr 19, 2026
ipakhomov
ipakhomov requested changes Apr 20, 2026
View reviewed changes

@ipakhomov ipakhomov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veliseev93 just one minor thing left

Comment thread README.md Outdated
ipakhomov
ipakhomov requested changes Apr 20, 2026
View reviewed changes
Comment thread README.md Outdated
@ipakhomov

ipakhomov commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@veliseev93 I've also published the alpha version of the package to NPM:
https://www.npmjs.com/package/@ronas-it/react-native-controlled-input

Could you please test if it installs and works as expected? Thanks.

@veliseev93

veliseev93 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

@ipakhomov I've made the suggested changes and also added support for the autoCorrect property and the onSubmitEditing callback.

@veliseev93

veliseev93 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

@veliseev93 I've also published the alpha version of the package to NPM: https://www.npmjs.com/package/@ronas-it/react-native-controlled-input

Could you please test if it installs and works as expected? Thanks.

Tested, seems to work as expected.

@veliseev93 veliseev93 assigned ipakhomov and unassigned veliseev93 Apr 22, 2026
@ipakhomov
ipakhomov merged commit 2c3cc81 into main Apr 22, 2026
1 check passed
@ipakhomov
ipakhomov deleted the 86c6wprt8-add-lib branch April 22, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ipakhomov ipakhomov ipakhomov requested changes

Assignees

@ipakhomov ipakhomov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veliseev93 @ipakhomov