Make loading savegames deterministic - #1970
Draft
Flamefire wants to merge 10 commits into
Draft
Conversation
After C++11 the outcome is specified by the standard for the standard PRNGs. Hence we can use a generic function for serialization. Add those and tests.
C++17 introduced `std::clamp` which makes passing a type from std namespace (such as chrono-types) ambiguous in the semi-recursive call. Use constexpr-ifs and `std::clamp` in teh final path.
It's the same as `isSoldier` so rename/remove it.
- Use `constexpr` instead of `const` - Use `[[maybe_unused]]` where applicable - Remove includes - Also shorten array-types to use CTAD instead of specifying the template params explicitely
Flamefire
force-pushed
the
save-rng-state
branch
from
August 24, 2026 18:17
377619e to
e82a558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the RNGs for in savegames are seeded with zero. This means continuing a loaded savegame will be different than the game played at that point.
Implement saving the current RNG states.