Conversation
mikeharv
approved these changes
Aug 12, 2026
mikeharv
left a comment
Contributor
There was a problem hiding this comment.
It might be worth calling out that this could potentially result in tiny visual differences, especially for applications that rely upon reference images for automated regression testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR clamps text width and workspace translation to integer values, and workspace scale to 3 decimals. Previously these were unbounded, typically leading to 14 digits of decimal precision, which is obviously unnecessary, and more computationally intensive.
Test Coverage
All tests pass, and I visually inspected the blocks and zooming.