fix(events): remove stale manual landing pages superseded by #701 - #778
fix(events): remove stale manual landing pages superseded by #701#778Adi-xt wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Adi-xt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTwo event landing page modules were deleted. Their Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes duplicate manual landing pages while preserving the plugin-generated routes, with no actionable merge-blocking risk remaining after normal checks. Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mesutoezdil
left a comment
There was a problem hiding this comment.
fix is correct: both slugs are in src/data/events.js and only index.js remains under src/pages/landing, matching what #701 did. blockers: dco fails, the commit has no sign off, amend with git commit -s and force push. the docs health ci did not run, rebase to trigger it. and please use the pr template, kind and checklist are missing.
| @@ -1,3 +0,0 @@ | |||
| import EventLanding from "@site/src/components/EventLanding"; | |||
|
|
|||
There was a problem hiding this comment.
verified: the plugin route covers this slug from events.js line 108, safe to delete.
There was a problem hiding this comment.
Thanks for the review! I’ve fixed the DCO issue by amending the commit with the required Signed-off-by line and force-pushed the updated commit.
I’ll also rebase onto the latest master to trigger the docs health CI, and update the PR description to follow the repository template with the required kind and checklist sections.
…HAMi#701 Signed-off-by: Adi-xt <adiadityadin@gmail.com>
ee8ca87 to
cb2e2c4
Compare
|
Thanks for the review! I’ve addressed the DCO requirement and rebased locally as requested. During the rebase, Git detected that the same fix is now already present in Since the fix was independently incorporated into |
PR: Remove stale manual landing pages superseded by #701
Title
fix(events): remove stale manual landing pages causing duplicate route warnings
Description
Problem
Running
npm run buildemits duplicate route warnings for two event landing pages, in bothenandzhlocales:Root cause
src/plugins/events/index.jsiterates overlandingEventsand programmatically registers a route for each event at/landing/${event.slug}, renderingEventLanding.jswith the event'sslugprop.However,
src/pages/landing/coscup-2026.jsandsrc/pages/landing/opensource-summit-korea.jsare manual page files that render the exact same component with the exact same prop:Since Docusaurus auto-generates routes for any file under
src/pages/, this creates a route twice — once from the filesystem router, once from the plugin.This is the same class of issue fixed in #701 ("generalize event landing page routes from data"), which removed two other stale manual pages (
kcd-vietnam.js,kubecon-japan.js) for the identical reason but missed these two.Fix
Removed the two redundant manual page files:
src/pages/landing/coscup-2026.jssrc/pages/landing/opensource-summit-korea.jsThe plugin already handles routing/rendering for these events via
src/data/events.js.Verification
npm run build— duplicate route warnings no longer appear for eitherenorzhlocale; both builds compile and generate successfully.npm run serve— manually visited/landing/coscup-2026,/landing/opensource-summit-korea, and their/zh/equivalents; all four render correctly via the plugin-generated route.Summary by CodeRabbit