Skip to content

fix(events): remove stale manual landing pages superseded by #701 - #778

Open
Adi-xt wants to merge 1 commit into
Project-HAMi:masterfrom
Adi-xt:fix/remove-stale-landing-pages
Open

fix(events): remove stale manual landing pages superseded by #701#778
Adi-xt wants to merge 1 commit into
Project-HAMi:masterfrom
Adi-xt:fix/remove-stale-landing-pages

Conversation

@Adi-xt

@Adi-xt Adi-xt commented Aug 15, 2026

Copy link
Copy Markdown

PR: Remove stale manual landing pages superseded by #701

Title

fix(events): remove stale manual landing pages causing duplicate route warnings

Description

Problem

Running npm run build emits duplicate route warnings for two event landing pages, in both en and zh locales:

[WARNING] Duplicate routes found!
- Attempting to create page at /landing/coscup-2026, but a page already exists at this route.
- Attempting to create page at /landing/opensource-summit-korea, but a page already exists at this route.
This could lead to non-deterministic routing behavior.

Root cause

src/plugins/events/index.js iterates over landingEvents and programmatically registers a route for each event at /landing/${event.slug}, rendering EventLanding.js with the event's slug prop.

However, src/pages/landing/coscup-2026.js and src/pages/landing/opensource-summit-korea.js are manual page files that render the exact same component with the exact same prop:

import EventLanding from "@site/src/components/EventLanding";
export default () => <EventLanding slug="coscup-2026" />;

Since Docusaurus auto-generates routes for any file under src/pages/, this creates a route twice — once from the filesystem router, once from the plugin.

This is the same class of issue fixed in #701 ("generalize event landing page routes from data"), which removed two other stale manual pages (kcd-vietnam.js, kubecon-japan.js) for the identical reason but missed these two.

Fix

Removed the two redundant manual page files:

  • src/pages/landing/coscup-2026.js
  • src/pages/landing/opensource-summit-korea.js

The plugin already handles routing/rendering for these events via src/data/events.js.

Verification

  • npm run build — duplicate route warnings no longer appear for either en or zh locale; both builds compile and generate successfully.
  • npm run serve — manually visited /landing/coscup-2026, /landing/opensource-summit-korea, and their /zh/ equivalents; all four render correctly via the plugin-generated route.

Summary by CodeRabbit

  • Removed Pages
    • Removed the COSCUP 2026 landing page.
    • Removed the Open Source Summit Korea landing page.

@hami-robot
hami-robot Bot requested review from archlitchi and rootsongjc August 15, 2026 05:27
@hami-robot

hami-robot Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Adi-xt
Once this PR has been reviewed and has the lgtm label, please assign windsonsea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit cb2e2c4
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a87385622611500083e55b4
😎 Deploy Preview https://deploy-preview-778--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a274dc7-38c5-474e-a8da-562936b8e1d0

📥 Commits

Reviewing files that changed from the base of the PR and between b5a333c and cb2e2c4.

📒 Files selected for processing (2)
  • src/pages/landing/coscup-2026.js
  • src/pages/landing/opensource-summit-korea.js
💤 Files with no reviewable changes (2)
  • src/pages/landing/coscup-2026.js
  • src/pages/landing/opensource-summit-korea.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Two event landing page modules were deleted. Their EventLanding imports and default exports were removed.

Changes

Cohort / File(s) Summary
Event landing page cleanup
src/pages/landing/coscup-2026.js, src/pages/landing/opensource-summit-korea.js
Deletes both landing page modules and their EventLanding component exports.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cb2e2

This change removes duplicate manual landing pages while preserving the plugin-generated routes, with no actionable merge-blocking risk remaining after normal checks.

Suggested labels: kind/cleanup

Suggested reviewers: rootsongjc, archlitchi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of stale manual landing pages that duplicate generated event routes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mesutoezdil mesutoezdil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix is correct: both slugs are in src/data/events.js and only index.js remains under src/pages/landing, matching what #701 did. blockers: dco fails, the commit has no sign off, amend with git commit -s and force push. the docs health ci did not run, rebase to trigger it. and please use the pr template, kind and checklist are missing.

Comment thread src/pages/landing/coscup-2026.js Outdated
@@ -1,3 +0,0 @@
import EventLanding from "@site/src/components/EventLanding";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified: the plugin route covers this slug from events.js line 108, safe to delete.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I’ve fixed the DCO issue by amending the commit with the required Signed-off-by line and force-pushed the updated commit.

I’ll also rebase onto the latest master to trigger the docs health CI, and update the PR description to follow the repository template with the required kind and checklist sections.

@Adi-xt
Adi-xt force-pushed the fix/remove-stale-landing-pages branch from ee8ca87 to cb2e2c4 Compare August 20, 2026 17:24
@coderabbitai coderabbitai Bot added the kind/cleanup Refactoring, config, or tidy-up with no behavior change label Aug 20, 2026
@Adi-xt

Adi-xt commented Aug 20, 2026

Copy link
Copy Markdown
Author

Thanks for the review! I’ve addressed the DCO requirement and rebased locally as requested. During the rebase, Git detected that the same fix is now already present in master via c151fd30, so my commit was skipped as an already-applied change.

Since the fix was independently incorporated into master, would you prefer that I keep this PR open for attribution, or close it and work on another issue?

@Adi-xt
Adi-xt requested a review from mesutoezdil August 20, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui kind/cleanup Refactoring, config, or tidy-up with no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants