Merge links into nodes: Link class and Branch class derive from new Edge class - #1546
Merged
Merged
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…ent and output etc Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Jerry-Jinfeng-Guo
added
feature
Signed-off-by: Jerry Guo <jerryguo@rocinantemac.home>
I, Jerry Guo <guojinfeng8621@gmail.com>, hereby add my Signed-off-by to this commit: a6a6355 Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
mgovers
reviewed
Aug 24, 2026
mgovers
left a comment
mgovers
left a comment
Member
There was a problem hiding this comment.
the rest of the PR LGTM.
Please update the name of the PR according to naming convention
Jerry-Jinfeng-Guo
changed the title
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
Jerry-Jinfeng-Guo
enabled auto-merge
August 24, 2026 14:22
nitbharambe
reviewed
Aug 24, 2026
Signed-off-by: Jerry Guo <guojinfeng8621@gmail.com>
|
mgovers
approved these changes
Aug 25, 2026
mgovers
reviewed
Aug 25, 2026
Jerry-Jinfeng-Guo
disabled auto-merge
August 25, 2026 09:16
Jerry-Jinfeng-Guo
enabled auto-merge
August 25, 2026 09:16
appleweiping
added a commit
to appleweiping/power-grid-model
that referenced
this pull request
Aug 25, 2026
Register Edge as retrievable in the current sensor output test state after the topology base migration in PowerGridModel#1546. Signed-off-by: Weiping Yan <152196713+appleweiping@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the registration change to component
Link:Edgeclass as base class for bothLinkandBranchEdgeclass and new deriving relationshipRegistration of
Linkunder different conditions to different code paths is scoped out and will come in a follow up PR.