Skip to content

fix(ui): sync color picker chroma - #966

Closed
saadndm wants to merge 1 commit into
Polyfrost:v1from
saadndm:fix-chroma
Closed

fix(ui): sync color picker chroma#966
saadndm wants to merge 1 commit into
Polyfrost:v1from
saadndm:fix-chroma

Conversation

@saadndm

@saadndm saadndm commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

  • Use PolyColor chroma timing for the color preview ui instead of creating a separate animation

Related Issue(s)

Fixes #708

Checklist

  • I made a clear description of what was changed
  • I stated why these changes were necessary
  • I updated documentation or said what needs to be updated
  • I made sure these changes are backwards compatible
  • This pull request is for one feature/bug fix

@saadndm
saadndm marked this pull request as draft August 14, 2026 01:51
@saadndm

saadndm commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Some chroma stuff still broken

@saadndm

saadndm commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Closing, #708 is a bigger problem, the chroma color is passed through animateColorAsState every frame, which always lags behind. Maybe we should redesign PolyColor idk

@saadndm saadndm closed this Aug 15, 2026
@saadndm
saadndm deleted the fix-chroma branch August 15, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

chroma not syncing

1 participant