Fix JOSS review edits: paper rendering and README links - #494
Merged
Conversation
- Remove manual 'Figure 1:' prefix from the paper figure caption so the rendered paper no longer shows 'Figure 1: Figure 1: ...' - Double-brace BibTeX institution fields containing 'and' so citeproc no longer splits them into 'National Institute of Economic; Social Research' and 'Beeck Center for Social Impact; Innovation' - Point the README Documentation links at existing docs pages (the core-concepts and per-country model pages did not exist) - Add CONTRIBUTING.md with issue-reporting, support, and development guidelines, which the README already linked to Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the fixable defects from the first-pass JOSS review (openjournals/joss-reviews#11115 (comment)).
Paper
paper.mdbegan with a manual "Figure 1:" prefix, and the JOSS pipeline adds its own figure numbering, producing "Figure 1: Figure 1: …". Removed the manual prefix.institutionfields containing an unbraced "and" were split into name lists by citeproc, rendering as "National Institute of Economic; Social Research" and "Beeck Center for Social Impact; Innovation". Double-braced the three affected fields inpaper.bib.README 404s
docs/core-concepts.md,docs/country-models-uk.md, anddocs/country-models-us.mddo not exist. Repointed the bullets at the pages that cover that content: docs/microsim.md, docs/countries.md, and docs/methodology/model-architecture.md. Verified every relative link in the README now resolves.CONTRIBUTING.mdcovering how to report issues, seek support, set up a development environment, and open pull requests (with a pointer to the full guide indocs/dev.md), which should also address the community-guidelines item on the review checklist.🤖 Generated with Claude Code