Skip to content

Fix compare tab not checking socket colours #10252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −0
Open

Fix compare tab not checking socket colours #10252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions spec/System/TestCompareTab_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,20 @@ describe("CompareTab", function()
assert.is_false(control:IsShown())
end
end)
it("reproduces matching-socket gem quality when comparing a build with itself", function()
newBuild()
build.itemsTab:CreateDisplayItemFromRaw(
"Rarity: RARE\nTest Subject\nSage's Robe\nQuality: 0\nSockets: B-B-B\nImplicits: 0\n")
build.itemsTab:AddDisplayItem()
build.skillsTab:PasteSocketGroup("Slot: Body Armour\nFireball 20/0 1\n")
runCallback("OnFrame")
assert.are.equals(10, build.calcsTab.mainOutput.GemQuality)

-- doesn't actually save to a file, just encodes as xml
local entry = new("CompareEntry"):CompareEntry(build:SaveDB("code"), "Self")

assert.is_true(entry.skillsTab.socketGroupList[1].gemList[1].matchesSocket)
assert.are.equals(build.calcsTab.mainOutput.GemQuality, entry.calcsTab.mainOutput.GemQuality)
assert.are.equals(build.calcsTab.mainOutput.CombinedDPS, entry.calcsTab.mainOutput.CombinedDPS)
end)
end)
3 changes: 3 additions & 0 deletions src/Classes/CompareEntry.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ function CompareEntryClass:LoadFromXML(xmlText)
end

self:SyncCalcsSkillSelection()
-- reprocess socket groups as they might depend on items which don't necessarily load first.
self.skillsTab:UpdateSocketGroups()
wipeGlobalCache()
self.calcsTab:BuildOutput()
self.buildFlag = false
Expand Down Expand Up @@ -248,6 +250,7 @@ end
function CompareEntryClass:Rebuild()
wipeGlobalCache()
self.outputRevision = self.outputRevision + 1
self.skillsTab:UpdateSocketGroups()
self.calcsTab:BuildOutput()
self.buildFlag = false
end
Expand Down
Loading