Skip to content

Fix Sirus Meteor not dealing Chaos Damage #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Aug 18, 2026
+6 −3
Merged

Fix Sirus Meteor not dealing Chaos Damage #10243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Modules/CalcDefence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1750,9 +1750,12 @@ function calcs.buildDefenceEstimations(env, actor)
local gainAsPercent = enemyDB:Sum("BASE", enemyCfg, (damageType.."DamageGainAs"..damageTypeTo)) / 100
local conversionPercent = conversions[damageTypeTo] / 100
local skillConversionPercent = conversions[damageTypeTo.."skill"] / 100
if skillConversionPercent > 0 and damageType == "Physical" and damageTypeTo ~= "Chaos" then
local physBonus = 1 + data.monsterPhysConversionMultiTable[env.enemyLevel] / 100
conversionPercent = conversionPercent + skillConversionPercent * physBonus
if skillConversionPercent > 0 then
if damageType == "Physical" and damageTypeTo ~= "Chaos" then
local physBonus = 1 + data.monsterPhysConversionMultiTable[env.enemyLevel] / 100
skillConversionPercent = skillConversionPercent * physBonus
end
conversionPercent = conversionPercent + skillConversionPercent
end
if gainAsPercent > 0 or conversionPercent > 0 then
enemyDamageConversion[damageTypeTo] = enemyDamageConversion[damageTypeTo] or { }
Expand Down
Loading