Skip to content

Fix mirrored items in character imports - #10237

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/import-mirrored-items
Open

Fix mirrored items in character imports#10237
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/import-mirrored-items

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes # N/A

Description of the problem being solved:

Mirrored items were not displaying the "Mirrored" tag when imported via the character import workflow. This is because GGG's item API uses the duplicated field on mirrored items, but the character import workflow was only checking itemData.mirrored.

This maps itemData.duplicated to PoB's existing mirrored state while retaining itemData.mirrored as a compatibility fallback.

The existing 3.29 item API import test now supplies duplicated = true and verifies that the resulting item is mirrored.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

See above

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant