Enable nullable annotations in ServiceControl.Persistence - #5774
Open
rbev wants to merge 3 commits into
Open
Conversation
rbev
commented
Aug 14, 2026
johnsimons
approved these changes
Aug 14, 2026
johnsimons
left a comment
johnsimons
left a comment
Member
There was a problem hiding this comment.
Just a few questions along the way
| Body = storedBody, | ||
| BodyStoredExternally = storeExternally, | ||
| ExceptionInfo = failure.ExceptionInfo | ||
| ExceptionInfo = failure.ExceptionInfo ?? "" |
Member
There was a problem hiding this comment.
"" should probably use string.Empty?
| { | ||
| public string Id { get; set; } | ||
| public object DispatchContext; | ||
| public string? Id { get; set; } |
Member
There was a problem hiding this comment.
that is weird? the id can be null!
Contributor
Author
There was a problem hiding this comment.
These null ids are because they are DB generated ids
| } | ||
|
|
||
| public string Id { get; set; } | ||
| public string? Id { get; set; } |
rbev
force-pushed
the
rhys/enable-nullable
branch
from
August 14, 2026 07:25
e803e18 to
856cca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables nullable annotations in ServiceControl.Persistence
The change is strives to avoid any functional code changes to above the persistence seam where possible by codifying the existing usage into the annotations based upon object creation or consumption patterns.