Fixing error for RK45 on spherical grids - #2827
Merged
Merged
Conversation
erikvansebille
commented
Aug 14, 2026
| if self.fieldset.U.grid._mesh.is_spherical(): | ||
| self.fieldset.RK45_tol /= ( | ||
| self.fieldset.U.grid.deg2m | ||
| ) # TODO does not account for zonal variation in meter -> degree conversion |
Member
Author
There was a problem hiding this comment.
I don't think this TODO is relevant anymore - we didn't do this in v3 either and it would require a major refactoring
erikvansebille
commented
Aug 14, 2026
| if kernel == AdvectionRK45: | ||
| fieldset.add_context("RK45_tol", rtol) | ||
| fieldset.add_context("RK45_min_dt", 1) | ||
| fieldset.add_context("RK45_min_dt", 10) |
Member
Author
There was a problem hiding this comment.
For a (slight) speedup of the tests
VeckoTheGecko
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I just came across this error in RK45 - which apparently wasn't tested on spherical grids.
This PR adds such a test and fixes the AttributeError
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None