Skip to content

Avoid the deprecated generic timedelta unit in timedelta conversion #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sujeito-operator wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid the deprecated generic timedelta unit in timedelta conversion #2826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/parcels/_core/utils/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from __future__ import annotations

import functools
import operator
from datetime import datetime, timedelta
from typing import TYPE_CHECKING, Literal, TypeVar, cast

Expand Down Expand Up @@ -182,7 +184,10 @@ def maybe_convert_python_timedelta_to_numpy(dt: timedelta | np.timedelta64) -> n
dts.append(np.timedelta64(value, np_unit))

if dts:
return sum(dts)
# Not `sum`: it starts from the integer 0, and `0 + np.timedelta64(...)` uses
# numpy's deprecated 'generic' timedelta unit. Adding the parts to each other
# keeps the same result unit without an integer start value.
return functools.reduce(operator.add, dts)
else:
return np.timedelta64(0, "s")
except Exception as e:
Expand Down