Skip to content

Fix ProblemExtensions.sciml defaulting to non-None - #513

Open
dweindl wants to merge 1 commit into
PEtab-dev:mainfrom
dweindl:fix512
Open

Fix ProblemExtensions.sciml defaulting to non-None#513
dweindl wants to merge 1 commit into
PEtab-dev:mainfrom
dweindl:fix512

Conversation

@dweindl

@dweindl dweindl commented Aug 13, 2026

Copy link
Copy Markdown
Member

Fixes #512.

In some places, problem.extensions.sciml was assumed to be None for non-sciml problems, but it wasn't. In other places it was assumed to always be a SciMLExt instance. I find the former more intuitive and updated the code accordingly.

@dweindl
dweindl requested a review from BSnelling August 13, 2026 14:38
@dweindl
dweindl requested a review from a team as a code owner August 13, 2026 14:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.75%. Comparing base (6629df6) to head (35ec295).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   75.80%   75.75%   -0.06%     
==========================================
  Files          65       65              
  Lines        7357     7357              
  Branches     1323     1323              
==========================================
- Hits         5577     5573       -4     
- Misses       1280     1285       +5     
+ Partials      500      499       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

petab_sciml ModuleNotFoundError with non-SciML problems

3 participants