Skip to content

Precommit upgrade - #510

Merged
dweindl merged 4 commits into
PEtab-dev:mainfrom
dweindl:precommit-upgrade
Aug 12, 2026
Merged

Precommit upgrade#510
dweindl merged 4 commits into
PEtab-dev:mainfrom
dweindl:precommit-upgrade

Conversation

@dweindl

@dweindl dweindl commented Aug 12, 2026

Copy link
Copy Markdown
Member

Addressing unparenthesized implicit string concatenation, implicit Optional, subprocess.run without explicit check argument and some others.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.17757% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.57%. Comparing base (73b680c) to head (64eb595).

Files with missing lines Patch % Lines
petab/petablint.py 0.00% 3 Missing ⚠️
petab/v2/converters.py 25.00% 2 Missing and 1 partial ⚠️
petab/v2/core.py 76.92% 3 Missing ⚠️
petab/v2/lint.py 66.66% 1 Missing and 1 partial ⚠️
petab/v2/petab1to2.py 50.00% 1 Missing and 1 partial ⚠️
petab/v1/lint.py 50.00% 1 Missing ⚠️
petab/v1/parameters.py 75.00% 1 Missing ⚠️
petab/v2/_helpers.py 0.00% 1 Missing ⚠️
petab/v2/extensions/sciml_lint.py 0.00% 1 Missing ⚠️
petab/v2/models/model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   75.54%   75.57%   +0.03%     
==========================================
  Files          65       65              
  Lines        7359     7357       -2     
  Branches     1325     1323       -2     
==========================================
+ Hits         5559     5560       +1     
+ Misses       1296     1293       -3     
  Partials      504      504              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
dweindl marked this pull request as ready for review August 12, 2026 09:40
@dweindl
dweindl requested review from a team and m-philipps as code owners August 12, 2026 09:40

@dilpath dilpath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl
dweindl merged commit 4d9422b into PEtab-dev:main Aug 12, 2026
7 checks passed
@dweindl
dweindl deleted the precommit-upgrade branch August 12, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants