windows: Call rsync with the correct version of ssh

actions/rsync-cache/dist/commit.js

@@ -30797,7 +30797,6 @@ class Rsync {
     this.ssh_dir = `${this.ssh_user}@${this.ssh_host}:${this.name}/${this.key}/`;
 
     this._validate();
-    this._set_vars();
   }
 
   // Ensure all our settings look good.
@@ -30820,10 +30819,12 @@ class Rsync {
   }
 
   // Prepare some variables.
-  _set_vars() {
+  async _set_vars() {
+    const ssh_exe = await this._find_ssh();
+
     // The SSH command line.
     const ssh_command = [
-      "ssh",
+      ssh_exe,
       "-i",
       this.ssh_key_file,
       "-p",
@@ -30849,12 +30850,31 @@ class Rsync {
     ];
   }
 
+  // Try to find the path to SSH.
+  async _find_ssh() {
+    if (this.core.platform.isWindows) {
+      const base = "C:\\ProgramData\\chocolatey\\lib\\rsync\\tools";
+      const files = await this.fs.readdir(base, { recursive: true });
+
+      for (const file of files) {
+        if (file.endsWith("\\ssh.exe") || file.endsWith("/ssh.exe")) {
+          return `${base}\\${file}`;
+        }
+      }
+
+      throw new Error(`unable to find ssh.exe on Windows`);
+    } else {
+      return "ssh";
+    }
+  }
+
   // Run rsync with extra arguments and return its exit code.
   async run(additional_arguments = []) {
     if (this.disabled) {
       return 0;
     }
 
+    await this._set_vars();
     let exit_code = -1;
 
     try {

actions/rsync-cache/dist/restore.js

@@ -30797,7 +30797,6 @@ class Rsync {
     this.ssh_dir = `${this.ssh_user}@${this.ssh_host}:${this.name}/${this.key}/`;
 
     this._validate();
-    this._set_vars();
   }
 
   // Ensure all our settings look good.
@@ -30820,10 +30819,12 @@ class Rsync {
   }
 
   // Prepare some variables.
-  _set_vars() {
+  async _set_vars() {
+    const ssh_exe = await this._find_ssh();
+
     // The SSH command line.
     const ssh_command = [
-      "ssh",
+      ssh_exe,
       "-i",
       this.ssh_key_file,
       "-p",
@@ -30849,12 +30850,31 @@ class Rsync {
     ];
   }
 
+  // Try to find the path to SSH.
+  async _find_ssh() {
+    if (this.core.platform.isWindows) {
+      const base = "C:\\ProgramData\\chocolatey\\lib\\rsync\\tools";
+      const files = await this.fs.readdir(base, { recursive: true });
+
+      for (const file of files) {
+        if (file.endsWith("\\ssh.exe") || file.endsWith("/ssh.exe")) {
+          return `${base}\\${file}`;
+        }
+      }
+
+      throw new Error(`unable to find ssh.exe on Windows`);
+    } else {
+      return "ssh";
+    }
+  }
+
   // Run rsync with extra arguments and return its exit code.
   async run(additional_arguments = []) {
     if (this.disabled) {
       return 0;
     }
 
+    await this._set_vars();
     let exit_code = -1;
 
     try {

actions/rsync-cache/src/rsync.js

@@ -43,7 +43,6 @@ export default class Rsync {
     this.ssh_dir = `${this.ssh_user}@${this.ssh_host}:${this.name}/${this.key}/`;
 
     this._validate();
-    this._set_vars();
   }
 
   // Ensure all our settings look good.
@@ -66,10 +65,12 @@ export default class Rsync {
   }
 
   // Prepare some variables.
-  _set_vars() {
+  async _set_vars() {
+    const ssh_exe = await this._find_ssh();
+
     // The SSH command line.
     const ssh_command = [
-      "ssh",
+      ssh_exe,
       "-i",
       this.ssh_key_file,
       "-p",
@@ -95,12 +96,31 @@ export default class Rsync {
     ];
   }
 
+  // Try to find the path to SSH.
+  async _find_ssh() {
+    if (this.core.platform.isWindows) {
+      const base = "C:\\ProgramData\\chocolatey\\lib\\rsync\\tools";
+      const files = await this.fs.readdir(base, { recursive: true });
+
+      for (const file of files) {
+        if (file.endsWith("\\ssh.exe") || file.endsWith("/ssh.exe")) {
+          return `${base}\\${file}`;
+        }
+      }
+
+      throw new Error(`unable to find ssh.exe on Windows`);
+    } else {
+      return "ssh";
+    }
+  }
+
   // Run rsync with extra arguments and return its exit code.
   async run(additional_arguments = []) {
     if (this.disabled) {
       return 0;
     }
 
+    await this._set_vars();
     let exit_code = -1;
 
     try {

actions/rsync-cache/test/rsync_test.js

@@ -56,6 +56,7 @@ class Deps {
       constructor(inputs) {
         this.inputs = inputs;
         this.notices = [];
+        this.platform = { isWindows: false };
       }
 
       getInput(key, options = {}) {
@@ -88,6 +89,7 @@ class Deps {
         this.files = new Map();
         this.modes = new Map();
         this.unlinked = [];
+        this.readdir_files = [];
       }
 
       async writeFile(name, content, encoding) {
@@ -101,6 +103,10 @@ class Deps {
       async unlink(file) {
         this.unlinked.push(file);
       }
+
+      async readdir() {
+        return this.readdir_files;
+      }
     })();
 
     return new Rsync({
@@ -198,6 +204,22 @@ test("can push the cache", async () => {
   assert(deps.core.notices.length == 0);
 });
 
+test("windows can find ssh.exe", async () => {
+  let deps = new Deps();
+  let rsync = deps.rsync();
+
+  deps.core.platform.isWindows = true;
+  deps.fs.readdir_files = ["fake\\foo", "bin\\ssh.exe"];
+
+  await rsync.push();
+
+  const args = deps.exec.commands.at(-1).at(1);
+  assert.equal("-e", args.at(0));
+
+  const ssh_command = args.at(1).split(" ").at(0);
+  assert(ssh_command.endsWith("bin\\ssh.exe"));
+});
+
 test("disabled on missing ssh key", async () => {
   for (const key of [null, "", "   "]) {
     let deps = new Deps();