ποΈπ§οΌdrop gulp-sourcemaps for gulp's own sourcemap support - #1791
Merged
Conversation
gulp-sourcemaps has had no release since November 2020, and it is the
only thing still pulling postcss 7 into the tree:
postcss@7.0.39
βββ¬ @gulp-sourcemaps/identity-map@2.0.1
βββ¬ gulp-sourcemaps@3.0.0
βββ @openinf/portal (devDependencies)
postcss 7 is end-of-life, so the five advisories filed against it β
four of them high β cannot be resolved by upgrading. Our own postcss
is 8.5.26 and was never affected. gulp has accepted `sourcemaps`
options on src and dest since v4, which is all this task was using
gulp-sourcemaps for.
Writing the map through dest also fixes it. `sourcemaps.write()` ran
before the rename, so gulp-rename rewrote the map's extension along
with the stylesheet's and left `maps/main.css.min.css` on disk while
the stylesheet asked for `maps/main.css.map`. The map has been dead
for as long as it has existed. It is now written after the rename, as
`maps/main.min.css.map`, which is what the stylesheet points at.
Emitted CSS is unchanged: both `main.css` and `main.min.css` are
byte-identical to before apart from the sourceMappingURL comment.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
β Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OpenINFbot
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gulp-sourcemapshas had no release since November 2020, and it is the only thing still pulling postcss 7 into the tree:postcss 7 is end-of-life, so the five advisories filed against it β four of them high β cannot be resolved by upgrading. Our own postcss is 8.5.26 and was never affected; the alerts persist purely because this one abandoned package drags v7 along behind it.
gulp has accepted
sourcemapsoptions onsrcanddestsince v4, which is all this task was usinggulp-sourcemapsfor.It also fixes the sourcemap, which has never worked
sourcemaps.write()ran beforegulp-rename, so the rename rewrote the map's extension along with the stylesheet's:maps/main.css.min.cssmaps/main.css.mapβmaps/main.min.css.mapmaps/main.min.css.mapβThe file was a perfectly valid source map the whole time β just written under a name nothing referenced, so devtools got a 404. Writing it through
destafter the rename lines the two up.Verification
Emitted CSS is unchanged. Built both revisions and diffed, ignoring the
sourceMappingURLcomment:nps build,nps test, andnps format.allall pass, withformat.allleaving the tree clean.After the change the lockfile contains no reference to
postcss@7orgulp-sourcemaps, and the build still succeeds with the orphaned store directories deleted β so nothing was quietly depending on them.What this does not fix
The remaining two alerts are
immutable@3.8.3, reached throughbrowser-sync. Browser-sync is current (2025-04), so that one needs either an upstream fix or a different dev server; it is dev-only and out of scope here.Part of working through #254 β though most of that list is release-inactivity noise rather than risk. This was the entry where an abandoned package and an unfixable advisory were the same problem.
List of any relevant issue numbers: #254